Changes the behavior of initial loading state.#25
Open
radfahrer wants to merge 1 commit intohupe1980:masterfrom
Open
Changes the behavior of initial loading state.#25radfahrer wants to merge 1 commit intohupe1980:masterfrom
radfahrer wants to merge 1 commit intohupe1980:masterfrom
Conversation
When using the `checkForExisting` option. Resolves hupe1980#24
Author
|
@hupe1980 I just wanted to reach out to see if you have seen this PR. If you haven't had time to review it, I understand. Let me know if there's anything you need from me. |
Owner
|
What kind of error do you have exactly? |
|
In my opinion, the original code is reasonable since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
checkForExistingoption, start the loading state asfalseand only set loading to true if the script does not already exist.Resolves #24